Disable broken integration test - lookup_aws_account_attribute #632

tremble · 2022-01-22T21:45:14Z

SUMMARY

After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False'

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

aws_account_attribute

ADDITIONAL INFORMATION

TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] *******************************************************************************************************************************
task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50
The full traceback is:
Traceback (most recent call last):
  File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute
    self._task.post_validate(templar=templar)
  File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate
    super(Task, self).post_validate(templar)
  File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate
    value = templar.template(getattr(self, name))
  File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template
    d[k] = self.template(
  File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template
    result = self.do_template(
  File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template
    res = ansible_concat(rf, convert_data, myenv.variable_start_string)
  File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat
    head = list(islice(nodes, 2))
  File "<template>", line 13, in root
  File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call
    return __obj(*args, **kwargs)
  File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup
    if isinstance(ran[0], NativeJinjaText):
KeyError: 0
fatal: [testhost]: FAILED! => {
    "changed": false
}

After going through the joys of bisecting recent changed ansible/ansible#75587 appears to have broken the test when running 'wantlist=False'

softwarefactory-project-zuul · 2022-01-22T22:12:59Z

Build succeeded.

ansible-galaxy-importer : SUCCESS in 4m 17s
build-ansible-collection : SUCCESS in 4m 51s
ansible-test-sanity-aws-ansible-python38 : SUCCESS in 9m 54s
ansible-test-sanity-aws-ansible-2.9-python38 : SUCCESS in 17m 05s
ansible-test-sanity-aws-ansible-2.11-python38 : SUCCESS in 10m 05s
ansible-test-units-amazon-aws-python38 : SUCCESS in 6m 44s
ansible-test-splitter : SUCCESS in 3m 10s
ansible-test-cloud-integration-aws-py38_0 : SKIPPED
ansible-test-cloud-integration-aws-py38_1 : SKIPPED
ansible-test-cloud-integration-aws-py38_2 : SKIPPED
ansible-test-cloud-integration-aws-py38_3 : SKIPPED
ansible-test-cloud-integration-aws-py38_4 : SKIPPED
ansible-test-cloud-integration-aws-py38_5 : SKIPPED

alinabuzachis · 2022-01-24T13:28:14Z

@tremble What do you think about opening an issue for the aws_account_attribute broken tests? I imagine we can track the status and fix when possible.

tremble · 2022-01-24T13:29:42Z

@tremble What do you think about opening an issue for the aws_account_attribute broken tests? I imagine we can track the status and fix when possible.

Done, I just forgot to link them.

ansible-zuul

LGTM!

@jillr

#630) [Breaking Change] Remove support for old boto SDK (not boto3/botocore) SUMMARY It is time. It's almost 3 years since the last code commit to the original boto library. We have deprecated and migrated. With 4.0.0 it is time for the last boto module and the relevant support code to be retired. Depends-On: #632 Depends-On: #639 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2.py plugins/module_utils/ec2.py plugins/doc_fragments/aws.py ADDITIONAL INFORMATION IMO we should branch stable-3 sooner rather than later and start the cleanup work. cc @jillr Reviewed-by: Brian Scholer <None> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>

…le-collections#632) Disable broken integration test - lookup_aws_account_attribute SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>

…#682) Disable broken integration test - lookup_aws_account_attribute Disable broken integration test - lookup_aws_account_attribute SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Alina Buzachis Reviewed-by: None SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION

patchback · 2022-04-21T13:16:22Z

Backport to stable-1.5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1.5/8b061bd8276af6884ba528705eccd0f06d95627c/pr-632

Backported as #785

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Disable broken integration test - lookup_aws_account_attribute SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit 8b061bd)

…#785) [PR #632/8b061bd8 backport][stable-1.5] Disable broken integration test - lookup_aws_account_attribute This is a backport of PR #632 as merged into main (8b061bd). SUMMARY After going through the joys of bisecting recent changes ansible/ansible#75587 appears to have broken the test when running 'wantlist=False' ISSUE TYPE Feature Pull Request COMPONENT NAME aws_account_attribute ADDITIONAL INFORMATION TASK [lookup_aws_account_attribute : Fetch all account attributes (wantlist=False)] ******************************************************************************************************************************* task path: /root/ansible_collections/amazon/aws/tests/output/.tmp/integration/lookup_aws_account_attribute-bjtiq49h-ÅÑŚÌβŁÈ/tests/integration/targets/lookup_aws_account_attribute/tasks/main.yaml:50 The full traceback is: Traceback (most recent call last): File "/root/ansible/lib/ansible/executor/task_executor.py", line 503, in _execute self._task.post_validate(templar=templar) File "/root/ansible/lib/ansible/playbook/task.py", line 283, in post_validate super(Task, self).post_validate(templar) File "/root/ansible/lib/ansible/playbook/base.py", line 650, in post_validate value = templar.template(getattr(self, name)) File "/root/ansible/lib/ansible/template/__init__.py", line 874, in template d[k] = self.template( File "/root/ansible/lib/ansible/template/__init__.py", line 842, in template result = self.do_template( File "/root/ansible/lib/ansible/template/__init__.py", line 1101, in do_template res = ansible_concat(rf, convert_data, myenv.variable_start_string) File "/root/ansible/lib/ansible/template/native_helpers.py", line 60, in ansible_concat head = list(islice(nodes, 2)) File "<template>", line 13, in root File "/usr/lib/python3.10/dist-packages/jinja2/runtime.py", line 349, in call return __obj(*args, **kwargs) File "/root/ansible/lib/ansible/template/__init__.py", line 1013, in _lookup if isinstance(ran[0], NativeJinjaText): KeyError: 0 fatal: [testhost]: FAILED! => { "changed": false } Reviewed-by: Mark Chappell <None>

Formally start the rds deprecation process SUMMARY The rds module is based upon the deprecated boto (not boto3/botocore) SDK and its functionality has been replaced by the rds_instance, rds_snapshot and rds_instance_info modules. ISSUE TYPE Feature Pull Request COMPONENT NAME rds ADDITIONAL INFORMATION See also ansible-collections#632 Reviewed-by: Felix Fontein <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: None <None>

Disable broken integration test - lookup_aws_account_attribute

9667259

After going through the joys of bisecting recent changed ansible/ansible#75587 appears to have broken the test when running 'wantlist=False'

tremble mentioned this pull request Jan 22, 2022

[Breaking Change] Remove support for old boto SDK (not boto3/botocore) #630

Merged

alinabuzachis approved these changes Jan 24, 2022

View reviewed changes

tremble mentioned this pull request Jan 24, 2022

lookup_aws_account_attribute integration test broken #633

Closed

1 task

tremble added the gate label Jan 24, 2022

ansible-zuul bot approved these changes Jan 24, 2022

View reviewed changes

ansible-zuul bot merged commit 8b061bd into ansible-collections:main Jan 24, 2022

tremble deleted the tests/disable/lookup_aws_account_attribute branch January 28, 2022 14:00

tremble added the backport-1.5 PR should be backported to the stable-1.5 branch label Apr 21, 2022

patchback bot mentioned this pull request Apr 21, 2022

[PR #632/8b061bd8 backport][stable-1.5] Disable broken integration test - lookup_aws_account_attribute #785

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable broken integration test - lookup_aws_account_attribute #632

Disable broken integration test - lookup_aws_account_attribute #632

tremble commented Jan 22, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jan 22, 2022

alinabuzachis commented Jan 24, 2022

tremble commented Jan 24, 2022

ansible-zuul bot left a comment

patchback bot commented Apr 21, 2022 •

edited

Loading

Disable broken integration test - lookup_aws_account_attribute #632

Disable broken integration test - lookup_aws_account_attribute #632

Conversation

tremble commented Jan 22, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Jan 22, 2022

alinabuzachis commented Jan 24, 2022

tremble commented Jan 24, 2022

ansible-zuul bot left a comment

Choose a reason for hiding this comment

patchback bot commented Apr 21, 2022 • edited Loading

Backport to stable-1.5: 💚 backport PR created

tremble commented Jan 22, 2022 •

edited

Loading

patchback bot commented Apr 21, 2022 •

edited

Loading